C++ strict conversion fixes for flatbuffer_builder.h (#8062) #8065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that those 3 failing tests are unrelated to this PR - CI is failing in general for those at this moment. |
dbaileychess
approved these changes
Sep 29, 2023
dbaileychess
approved these changes
Sep 29, 2023
Enables to compile flatbuffer_builder.h with strict settings -Wconversion -Wsign-conversion. Also, add asserts to verify the conversions.
greenrobot
force-pushed
the
8062-cpp-strict-conversion-fixes
branch
from
9f66ad2 to
986b9fc
Compare
|
Sorry for the delay, I was out on paternity leave. |
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
…oogle#8065) Enables to compile flatbuffer_builder.h with strict settings -Wconversion -Wsign-conversion. Also, add asserts to verify the conversions.
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
…oogle#8065) Enables to compile flatbuffer_builder.h with strict settings -Wconversion -Wsign-conversion. Also, add asserts to verify the conversions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables to compile flatbuffer_builder.h with strict settings -Wconversion -Wsign-conversion. Also, add asserts to verify the conversions.
Disclaimer why this matters: (very) strict compiler settings are often required in mission critical projects. The changes here address flatbuffer_builder.h, which provides essential functionality.