Optionally generate type prefixes and suffixes for python code #7857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c++
codegen
dbaileychess
previously approved these changes
Mar 15, 2023
|
@maxburke looks like it just needs to be synced at head. |
|
@dbaileychess What's left for this PR in order to be merged? |
|
@maxburke Sorry for the delay. For some reason I don't have a |
|
@dbaileychess done |
dbaileychess
approved these changes
Apr 26, 2023
|
Sorry, my day job has been keeping me busy. |
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
…e#7857) * optionally generate type prefixes and suffixes for python code * fix codegen error when qualified name is empty * generated code updated
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
…e#7857) * optionally generate type prefixes and suffixes for python code * fix codegen error when qualified name is empty * generated code updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a command line option to skip generation of the type prefixed/suffixed functions in Python code, for example for a Flatbuffer type MyType, this will skip generating "GetRootAsMyType", "MyTypeStart", "MyTypeEnd", "MyTypeAddSomeField", ...