Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linker errors on (Free|Open)BSD. #6860

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Fix linker errors on (Free|Open)BSD. #6860

merged 2 commits into from
Sep 27, 2021

Conversation

yesudeep
Copy link
Contributor

@yesudeep yesudeep commented Sep 23, 2021 •
edited
Loading

@github-actions github-actions bot added the codegen Involving generating code from schema label Sep 23, 2021
@yesudeep
Copy link
Contributor Author

I'm not sure how long one would have to wait for Bazel to address bazelbuild/bazel#12023 so adding this as a fix for FreeBSD and OpenBSD.

@aardappel
Copy link
Collaborator

@AustinSchuh

AustinSchuh
AustinSchuh suggested changes Sep 25, 2021
View reviewed changes
Copy link
Contributor

@AustinSchuh AustinSchuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment tying this back to the upstream bug? That will help us remove it when it is fixed upstream.

I also have a minor preference to putting the config settings in //:BUILD.bazel. If you feel strongly, go ahead and keep them here.

@yesudeep
Copy link
Contributor Author

Sure. Added.

AustinSchuh
AustinSchuh approved these changes Sep 25, 2021
View reviewed changes
Copy link
Contributor

@AustinSchuh AustinSchuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@aardappel aardappel merged commit 2dd2126 into google:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinSchuh AustinSchuh AustinSchuh approved these changes

Assignees
No one assigned
Labels
codegen Involving generating code from schema
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C++] Linker error: missing -lm flag on FreeBSD/OpenBSD for corresponding cmath usage.
3 participants
@yesudeep @aardappel @AustinSchuh