[TS/JS] Fix TS code gen after #6420

[ptitjes]

This PR fixes a code gen problem introduced in #6420. The generated code for "endXXStruct()" doesn't compile. I assume that there was a regexp used to replace .required by .IsRequired. It was also applied incorrectly to builder.requiredField.

To test it I did:

make
npm install
npm run test

It seem the make run did modifications to some generated .h files that are totally unrelated to my fix. I suspect that these were not correctly regenerated by a previous PR. I included those changes as a separate commit. Tell me if you want to drop this commit.

Also when I do cd test, sh generate_code.sh the changes on the .h are reverted and a whole lot of new .js|.ts|.d.ts files are created at the root of the tests directory and not in the tests/ts directory (which already contains the same files). Is that supposed to happen ? Please tell me what to do.

[google-cla]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[ptitjes]

@googlebot I fixed it.

[ptitjes]

@krojew Would you mind helping me make my two PRs pass the CIs ? I think the problems come from the generated files.

[aardappel]

@bjornharrtell

[krojew]

@ptitjes did you run tests/generate_code.sh after making changes?

[ptitjes]

@ptitjes did you run tests/generate_code.sh after making changes?

Hey @krojew! I tried but as I said in the description, it also generated lots of unrelated changes.

I will rebase and try again this week-end.

[bjornharrtell]

This is already fixed on master with #6495?

[ptitjes]

This is already fixed on master with #6495?

Hmm, yeah it seems @krojew redid the same fix. :( Closing.