-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Default strings and vectors: Parser + Rust support #6421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please rebase. |
|
Rebased and added more tests. @aardappel, PTAL again |
aardappel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good! Though not sure if this should go in without at least 1 language that uses this data.. I understand you're wanting to keep commits small, but it also has value to see new data actually used.
|
Can you undo the unrelated clang-format changes? Are you using our script, or at least |
|
This looks great.. ready to merge, unless you want anyone else to review it. |
|
@krojew, can I also get your review? |
|
@CasperN using flatbuffers::Parser;
TEST_EQ(false, Parser().Parse("enum e:e{}table T{p:[e]=[]"));with assertion:
Could you take a look at this problem? |
|
Should probably be fixed before #6353 |
|
dang it, I made the same mistake while doing optional scalars 🙄 |
First steps towards #6053:
This should go in after #6420