-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[C++17] Add compile-time reflection for fields. #6324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 24 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
aa39ddf
[C++17] Add compile-time reflection for fields.
no-more-secrets a1f366c
Fix int-conversion warning on MSVC.
no-more-secrets c662260
Try to fix std::to_string ambiguity on MSVC.
no-more-secrets a895c01
Merge branch 'master' into cpp17-field-traits
no-more-secrets 2692175
Merge branch 'master' into cpp17-field-traits
no-more-secrets 4b458c2
Merge branch 'cpp17-field-traits' of ssh://github.com/dpacbach/flatbu…
no-more-secrets 94790e2
Fix clang-format diffs.
no-more-secrets 3f06697
Fix more clang-format diffs.
no-more-secrets 7575a2c
Fix last clang-format diff.
no-more-secrets 181220d
Enable C++17 build/test for VC 19 platform in CI.
no-more-secrets 5a42f2d
Forgot to add value to cmake command line variable.
no-more-secrets 9f8ff70
Various fixes/changes in response to @vglavnyy's feedback.
no-more-secrets b5e7679
Merge branch 'master' into cpp17-field-traits
no-more-secrets 44302e6
Replace "fields pack" with index-based getters.
no-more-secrets 36ee3b0
Fix MSVC error.
no-more-secrets 09e46b2
Fix clang-format diffs.
no-more-secrets 68ad486
getter_for method returns result instead of address-of-getter.
no-more-secrets 1859546
Merge branch 'master' into cpp17-field-traits
no-more-secrets 505a315
Merge branch 'cpp17-field-traits' of ssh://github.com/dpacbach/flatbu…
no-more-secrets dcdb4e7
Next round of reviewer suggestions.
no-more-secrets d4ed8a4
Use type instead of hardcoded struct name.
no-more-secrets 191029a
Fix clang-format diff.
no-more-secrets db4fa27
Add test for FieldType since it is not used in the stringify test.
no-more-secrets 17e75b5
Add fields_number field to Traits struct.
no-more-secrets 883390d
Merge branch 'master' of https://github.com/google/flatbuffers into c…
no-more-secrets 4bc3ca9
Add --cpp-static-reflection flag and put those features behind it.
no-more-secrets 8d7b9dc
Fix clang-format diffs.
no-more-secrets 5102108
Remove <tuple> include.
no-more-secrets File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this instead go into
base.hor similar?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd probably avoid that, because the
<tuple>header is a bit long and template heavy, and so we probably don't want to force users to include it unless they have this C++ static reflection feature enabled (with C++17).