VectorIterator as random_access_iterator

[krupnov]

Hi.

Is it possible to extend VectorIterator so it would be random access? It would be very useful for stl function like std::lower_bound, std::distance so on.
For now I have to implement all that functionality myself with Get function. LookupByKey already uses std::bsearch.

So please tell me what is the reason we don't have random access iterator?

The reason we have no random access iterator is because the person that originally wrote it didn't think about it, and you're the first one to notice :)

Are you able to make a PR?

[krupnov]

Yes.
If there is no problem with it I will try to make it next week.

Thanks :)

[krupnov]

Hi. I created patch and tried to push it. But I got 403 HTTP error.
Could you please help me?

I am doing:

git checkout -b vector_random_access_iterator
git push origin vector_random_access_iterator

And geting error:

error: The requested URL returned error: 403 while accessing https://github.com/google/flatbuffers.git/info/refs
fatal: HTTP request failed

My git version:
git --version
git version 1.7.9.5

Sorry. It is my first pull request. I think I need to make fork. :)

[krupnov]

OK.

I have done it with fork. Hope everything is fine now :)

[aardappel]

PR was merged.