Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to set the shadow sampling quality #8315

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

pixelflinger
Copy link
Collaborator

@pixelflinger pixelflinger commented Dec 13, 2024

FIXES=[379754325]

@pixelflinger pixelflinger added the internal Issue/PR does not affect clients label Dec 13, 2024
@pixelflinger pixelflinger requested a review from bejado December 13, 2024 22:45
@@ -337,6 +337,9 @@ utils::io::sstream& CodeGenerator::generateProlog(utils::io::sstream& out, Shade
generateSpecializationConstant(out, "CONFIG_SH_BANDS_COUNT",
+ReservedSpecializationConstants::CONFIG_SH_BANDS_COUNT, 3);

generateSpecializationConstant(out, "CONFIG_SHADOW_SAMPLING_METHOD",
+ReservedSpecializationConstants::CONFIG_SHADOW_SAMPLING_METHOD, 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would add a comment that 1 is PCF_LOW

@pixelflinger pixelflinger merged commit 377a110 into main Dec 18, 2024
12 checks passed
@pixelflinger pixelflinger deleted the ma/shadowquality branch December 18, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Issue/PR does not affect clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants