Add skeleton code of fgviewer #8303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Format the file
Add comment to fgviewer related lines Fix cmake commands
poweifeng
reviewed
Dec 11, 2024
|
|
||
| CivetServer* mServer; | ||
|
|
||
| tsl::robin_map<FrameGraphInfoKey, FrameGraphInfo> mViews; |
There was a problem hiding this comment.
I know we use robin_map in a lot of places, but we're thinking about moving away from it enventually. So for this, I would just suggest to stuck to the std::unordered_map, it's probably fine.
There was a problem hiding this comment.
Updated.
BTW, I'm wondering what's the different between using these two classes? And why do we want to use robin_map at the beginning?
Address the comments
show50726
force-pushed
the
dev/fgviewer
branch
from
ff0230c to
8e58dff
Compare
poweifeng
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fgviewerbeing built before the feature is readyfgviewerfolder tolibsand create some skeleton codes of debug server