Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix skinning bugs #2

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Fix skinning bugs #2

merged 1 commit into from
Aug 3, 2018

Conversation

romainguy
Copy link
Collaborator

  • We were not setting the bones ubo staging buffer size correctly
  • The bones UBO was never bound to the shader
  • The default values for the bones ubo wasn’t identity

@romainguy
Fix skinning bugs
5147ded 
- We were not setting the bones ubo staging buffer size correctly
- The bones UBO was never bound to the shader
- The default values for the bones ubo wasn’t identity
@romainguy romainguy merged commit 83db7e0 into master Aug 3, 2018
@romainguy romainguy deleted the rg/skinning branch August 3, 2018 19:04
This was referenced Aug 10, 2018
Closed
Closed
@Zefz Zefz mentioned this pull request Oct 30, 2018
Closed
@Raki Raki mentioned this pull request Feb 14, 2019
Closed
@amesgames amesgames mentioned this pull request Jul 16, 2019
Closed
@fishelegs fishelegs mentioned this pull request Aug 15, 2019
Closed
@geroge-d geroge-d mentioned this pull request Sep 3, 2019
Closed
@chandusam2002 chandusam2002 mentioned this pull request Nov 1, 2019
Closed
@geroge-d geroge-d mentioned this pull request Nov 9, 2019
Closed
@geroge-d geroge-d mentioned this pull request Nov 19, 2019
Closed
@geroge-d geroge-d mentioned this pull request Mar 26, 2020
Closed
@justinwilcox justinwilcox mentioned this pull request Apr 21, 2020
Closed
@daichen daichen mentioned this pull request Sep 11, 2020
Closed
rbsheth referenced this pull request in cpp-pm/filament Nov 13, 2020
@elisemorysc @prideout
@bejado @dsternfeld7 @rbsheth
Hunterize filament 1.9.8 (#1)
7530921 
* hunter v1.9.5

* remove defaults packages

* missing packages

* fix matdbg

* USe -fno-buildin for GNU and CLANG

* update packages

* Vulkan: add missing field to VmaVulkanFunctions.

* Add subpass parameter type to materials (google#3193)

* Fix TypeScript binding for TextureUsage.

* Add Dockerfile and test script for SwiftShader.

This adds a Dockerfile and a new bash script that makes it
east to invoke the appopriate Docker commands.

This does not yet enable a GitHub Action because of intermittent
issues that we have not yet ironed out.

* Add ability to specify post-process material output location (google#3205)

* Vulkan: improve the ReadPixels implementation.

This adds support for more format conversions and removes a bogus
assert that prevented ReadPixels within beginFrame / endFrame.
This was tested with:

    backend_test_mac --api vulkan --gtest_filter=BackendTest.ReadPixels

* Allow test_ReadPixels with SwiftShader.

* Vulkan: ReadPixels y-flip workaround.

* Makes it possible to have multiple instances of ImGuiHelper at the same time

This change fixes an issue where ImGuiHelper would crash on destruction if you created more than one instance at the same time.

This crash occurred when ImGui::DestroyContext() was called, because when the second instance was destroyed there was no current context causing it to crash.

This fixes it by making ImGuiHelper store and manage it's own context.

Having two instances of ImGuiHelper is useful in cases where you want to use imgui with multiple views.

* Vulkan: fix thread safety regression in Disposer.

This fixes a regression introduced by 548b28c manifesting as
intermittent assertions. The VulkanDisposer gc() should only be called
from the driver thread.

* Vulkan: Improve refcounting for vertex buffers.

This avoids the following validation error when clients create then
immediately destroy vertex buffers, index buffers, and uniform buffers.

        VUID-vkDestroyBuffer-buffer-00922

        Cannot free VkBuffer that is in use by a command buffer.

Buffers that are used across multiple frames were fine, but
create-and-destroy scenarios were problematic.

* Vulkan: fix leak with headless swap chain.

* Vulkan: fix destroy-while-used for UBOs.

* Fix Windows build.

* PlatformVkLinux now supports all combos of XLIB and XCB.

You can now build Filament with support for both X11 APIs, or neither.
If both are supported, run-time selection is achieved using a SwapChain
flag.

Supporting only one API at build time (or neither) is useful because our
list of "required" VkInstance extensions can vary according to which
API's are supported. During VkInstance creation, we do not have a priori
knowledge about what kinds of swap chains will be created. (headless vs
non-headless, XCB vs XLIB, etc)

Note that some Vulkan implementation (e.g. some builds of SwiftShader)
only support XCB.

* Add PNG output to test_ReadPixels.

* Merge duplicated implementations of toLinear().

* Fix iOS build break.

* Vulkan: make ReadPixels synchronous.

This makes it so that the PixelBufferDescriptor callback triggers at a
time consistent with other backends.

ReadPixels is still asynchronous in the sense that the callback is
triggered on the main thread. However, it is now guaranteed to trigger
during (or before) flushAndWait(), which is less surprising behavior.

* Vulkan: warn instead of panic for sampler overflow.

This makes behavior in release builds similar to the OpenGL backend.

In debug builds, we will still assert.

* Update RELEASE_NOTES for 1.9.6

* Bump version to 1.9.7

* Update RELEASE_NOTES for 1.9.7

* Version update

* update hunter version

* add opengl

* remove opengl

* Windows fixes (#1)

* Fix getopt (#2)

* fix linux build

* fix osx build

* civetweb 1.13

* update version

* add hunter mat tools flag

* remove civetweb from config

* revert civetweb

* add SPIRV-Tools-opt in config

* Update filament-hunter-config.cmake.in

* Update filament-hunter-config.cmake.in

Co-authored-by: Eli Semory <[email protected]>
Co-authored-by: Philip Rideout <[email protected]>
Co-authored-by: Ben Doherty <[email protected]>
Co-authored-by: dsternfeld7 <[email protected]>
Co-authored-by: Rahul Sheth <[email protected]>
Co-authored-by: Rahul Sheth <[email protected]>
@paulorrfilho paulorrfilho mentioned this pull request Mar 2, 2021
Closed
This was referenced Mar 15, 2021
Closed
Closed
@bigbigdaddy bigbigdaddy mentioned this pull request Jun 7, 2021
Closed
@gamepro65 gamepro65 mentioned this pull request Jul 22, 2021
Closed
@sniperPqc sniperPqc mentioned this pull request Sep 18, 2021
Closed
@drdla49 drdla49 mentioned this pull request Nov 5, 2021
Closed
@GGMU1987 GGMU1987 mentioned this pull request Nov 25, 2021
Closed
@geroge-d geroge-d mentioned this pull request Jan 26, 2022
Closed
@prideout prideout mentioned this pull request Mar 9, 2022
Closed
@lincolnfrog lincolnfrog mentioned this pull request Aug 30, 2022
Closed
@ccworld1000 ccworld1000 mentioned this pull request Sep 30, 2022
Closed
@arestory arestory mentioned this pull request Nov 10, 2022
Closed
@zurgeg zurgeg mentioned this pull request May 12, 2023
Closed
@YounthYue YounthYue mentioned this pull request May 17, 2023
Closed
@Daisiyou Daisiyou mentioned this pull request Jul 7, 2023
Closed
@Maliangxike Maliangxike mentioned this pull request Jul 18, 2023
Closed
@zy4944796 zy4944796 mentioned this pull request Aug 3, 2023
Closed
@ihsanulhaq89 ihsanulhaq89 mentioned this pull request Aug 10, 2023
Closed
@lukwsx lukwsx mentioned this pull request Sep 12, 2023
Closed
poweifeng added a commit that referenced this pull request Oct 3, 2023
@poweifeng
Fix build failures due to filamat lite removal #2
9065fe1
poweifeng added a commit that referenced this pull request Oct 3, 2023
@poweifeng
Fix build failures due to filamat lite removal #2 (#7224)
b4d6f97
@awkr awkr mentioned this pull request Oct 20, 2023
Closed
@oceanii oceanii mentioned this pull request Oct 26, 2023
Open
@machelel machelel mentioned this pull request Nov 13, 2023
Closed
plepers pushed a commit to plepers/filament that referenced this pull request Dec 9, 2023
@poweifeng @plepers
Fix build failures due to filamat lite removal google#2 (google#7224)
07e2b3b
@xiamingwei-sudo xiamingwei-sudo mentioned this pull request Mar 11, 2024
Open
poweifeng added a commit that referenced this pull request May 8, 2024
@poweifeng
address more comments #2
ee2050f
poweifeng added a commit that referenced this pull request May 8, 2024
@poweifeng
address more comments #2
26a0b3d
poweifeng added a commit that referenced this pull request May 8, 2024
@poweifeng
address more comments #2
ea6a67e
poweifeng added a commit that referenced this pull request May 8, 2024
@poweifeng
address more comments #2
2e88a97
@punkesta punkesta mentioned this pull request Jun 6, 2024
Open
@xiamingwei-sudo xiamingwei-sudo mentioned this pull request Jul 10, 2024
Closed
@linconz linconz mentioned this pull request Jul 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@romainguy