Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

All commits I made after forking. #26

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

CarloWood
Copy link

I can imagine you don't want the 'remove generated files' commit - although I consider it very bad practice to put generated files in a git repository; I had to re-run aclocal -m m4; autoheader; autoconf; automake --missing --foreign anyway because you used am version 1.14 to generate these files, which I don't have installed; which breaks building.

Removing 'using namespace std' and using the correct standard header names are just good C++ practice. You should probably merge those. The compiler warning thing is just a warning, but compiler warnings are annoying. Finally, if you'd be so kind to consider adding cwm4 support then I don't need to keep my own fork ;). This just adds a file configure.m4 which then allows fully automatic integration with other projects (that use cwm4) as git submodule (no configuration or editing of build system files required: just a git submodule add ... and done).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants