This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can imagine you don't want the 'remove generated files' commit - although I consider it very bad practice to put generated files in a git repository; I had to re-run aclocal -m m4; autoheader; autoconf; automake --missing --foreign anyway because you used am version 1.14 to generate these files, which I don't have installed; which breaks building.
Removing 'using namespace std' and using the correct standard header names are just good C++ practice. You should probably merge those. The compiler warning thing is just a warning, but compiler warnings are annoying. Finally, if you'd be so kind to consider adding cwm4 support then I don't need to keep my own fork ;). This just adds a file configure.m4 which then allows fully automatic integration with other projects (that use cwm4) as git submodule (no configuration or editing of build system files required: just a git submodule add ... and done).