Remove ASTHelpers.findSuperMethod.
#5014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this method is a massive trap with the surprising behaviour around `skipInterfaces`. I inlined and simplified a few which didn't seem to care about the interface-ness. PiperOrigin-RevId: 751414410
copybara-service
bot
force-pushed
the
test_748467891
branch
from
5b025da to
175f4c8
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
ASTHelpers.findSuperMethod.I think this method is a massive trap with the surprising behaviour around
skipInterfaces.I inlined and simplified a few which didn't seem to care about the interface-ness.