Add error message for obscure case with parameters. #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, if a user omitted the length of an integer parameter *and* used that parameter as an argument to an operator or function, the compiler with throw an `AttributeError` instead of providing a useful message. This is because the check that integer runtime parameters have an explicit size happened later than the function in `expression_bounds.py` that tried to use the size. This change moves the check earlier (incidentally spliting `check_constraints` into `check_constraints` and `check_early_constraints`), and also gives it a better error message.
|
Taking a look now! |
EricRahm
approved these changes
Dec 18, 2024
| @@ -319,6 +319,7 @@ def process_ir(ir, stop_before_step): | |||
| symbol_resolver.resolve_field_references, | |||
| type_check.annotate_types, | |||
| type_check.check_types, | |||
| constraints.check_early_constraints, | |||
There was a problem hiding this comment.
Out of curiosity does this additional pass add much overhead to the end-to-end codegen time?
There was a problem hiding this comment.
> python3 -m cProfile ./embossc --output-path ~/scratch ~/scratch/large.emb
25766374 function calls (23764959 primitive calls) in 17.613 seconds
Ordered by: cumulative time
ncalls tottime percall cumtime percall filename:lineno(function)
181/1 0.014 0.000 18.280 18.280 {built-in method builtins.exec}
[...]
1 0.000 0.000 0.003 0.003 constraints.py:717(check_early_constraints)
[...]
8 0.000 0.000 0.002 0.000 constraints.py:365(_check_type_requirements_for_parameter_type)
[...]
Looks like <0.02% of the overall compilation time. large.emb does have a few parameters, but is not parameter-heavy; I imagine that an .emb with a lot of parameters would pay a correspondingly higher compile time cost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, if a user omitted the length of an integer parameter and used that parameter as an argument to an operator or function, the compiler with throw an
AttributeErrorinstead of providing a useful message.This is because the check that integer runtime parameters have an explicit size happened later than the function in
expression_bounds.pythat tried to use the size.This change moves the check earlier (incidentally spliting
check_constraintsintocheck_constraintsandcheck_early_constraints), and also gives it a better error message.