Use bzlmod to manage dependencies #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will also make it easier to maintain emboss in the BCR (https://github.com/bazelbuild/bazel-central-registry/tree/main/modules/emboss).
|
I'm not too familiar with Bazel modules. Will this change affect anyone users of Emboss that are using Bazel? I suspect not, since this seems to just affect the equivalent of WORKSPACE (?), but I would want to confirm that. |
|
That's right, existing Bazel projects that pull in Emboss through their WORKSPACE will not be affected. |
|
Any blockers to merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will also make it easier to maintain emboss in the BCR (https://github.com/bazelbuild/bazel-central-registry/tree/main/modules/emboss).
Ideally we'd also set the
versionfield ofmodule, but the version value is unknown until the release workflow actually runs (because it encodes the release timestamp). In practice we should probably change the versioning scheme to pull the version number fromMODULE.bazel, but I imagine that requires some discussion.