Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of ConnectorArguments #515

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Cleanup of ConnectorArguments #515

merged 3 commits into from
Aug 9, 2024

Conversation

misolt
Copy link
Collaborator

@misolt misolt commented Aug 9, 2024

  • remove commented-out code
  • move the unrelated ZonedParser class to a separate file

@misolt misolt changed the title ConnectorArguments cleanup Clean up of ConnectorArguments Aug 9, 2024
@misolt misolt changed the title Clean up of ConnectorArguments Cleanup of ConnectorArguments Aug 9, 2024
@misolt misolt requested a review from dawidxc August 9, 2024 11:29
@misolt misolt marked this pull request as ready for review August 9, 2024 11:29
@misolt misolt merged commit 975d99b into google:main Aug 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawidxc dawidxc dawidxc approved these changes

@paolomorandini paolomorandini Awaiting requested review from paolomorandini paolomorandini is a code owner

@mjquinn-google mjquinn-google Awaiting requested review from mjquinn-google mjquinn-google is a code owner

@arotenberg-google arotenberg-google Awaiting requested review from arotenberg-google arotenberg-google is a code owner

@shevek-google shevek-google Awaiting requested review from shevek-google shevek-google is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misolt @dawidxc