Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ExtendableResultSetExtractor #406

Merged
merged 2 commits into from
May 28, 2024
Merged

Conversation

misolt
Copy link
Collaborator

@misolt misolt commented May 28, 2024

Currently, the return type of newCsvResultSetExtractor() is narrowed down from ResultSetExtractor<Summary> only to provide the withInterval() method.

Changing the return type to RSE<Summary> makes it easier to work on AbstractJdbcTask subclasses.

  • make withInterval() static
  • change the return type to RSE<Summary>
  • remove the redundant interface

@misolt misolt changed the title Interval method remove ExtendableResultSetExtractor May 28, 2024
@misolt misolt requested a review from dawidxc May 28, 2024 14:06
@misolt misolt marked this pull request as ready for review May 28, 2024 14:07
@misolt misolt merged commit fe60d08 into google:main May 28, 2024
2 checks passed
@misolt misolt deleted the interval-method branch June 4, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants