[GA4] Emit page_helpful events for page feedback
#1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
chalin
changed the title
page_helpful events for page feedback
|
/cc @fekete-robert |
chalin
force-pushed
the
chalin-im-page-helpful-event-2023-11-11
branch
4 times, most recently
from
5b5c69b
to
c4348b9
Compare
|
I don't have a setup where I could actually test it, but LGTM |
|
Thanks for the feedback @fekete-robert. Right, we'll have to iterate, if necessary, given that preview builds don't include analytics. This code was in use in another one of our projects, so there's a good chance it'll work here too. |
|
I want to test this, it may take a couple of more days. If you need this merged sooner I can approve it. |
chalin
force-pushed
the
chalin-im-page-helpful-event-2023-11-11
branch
from
c4348b9
to
9dc1514
Compare
|
LOL, I forgot that we don't have analytics setup yet for the User Guide! |
|
I'll test as soon as I can and report here. (Since the UG isn't using this new feature, then there's no rush.) |
|
Ok, feature tested! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
page_helpfulrather than aclickevent when the page feedback button is clicked. This makes it easier to view page feedback in the GA4 analytics console. FYI, the code in this PR has been used and vetted as part of the falco.org website, see Ensure page feedback works under GA4 falcosecurity/falco-website#974.max_valueemitted for "yes" events, whose default value is now 100Preview, e.g.: https://deploy-preview-1726--docsydocs.netlify.app/docs/adding-content/feedback/#search-engine-optimization-meta-tags -- navigate to the end of the page to see the feedback form