Skip to content

Use the latest version of the xml package #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Use the latest version of the xml package #59

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
818a1fa
Use the latest version of the xml package
nex3 Oct 13, 2020
b23d7bb
Fix CI
nex3 Oct 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 1.0.0-beta.11

* Use the latest version of the `xml` package.

# 1.0.0-beta.10

* **Breaking change:** All configurable variables are now defined as
Expand Down
5 changes: 2 additions & 3 deletions lib/src/chocolatey.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import 'package:archive/archive.dart';
import 'package:grinder/grinder.dart';
import 'package:meta/meta.dart';
import 'package:path/path.dart' as p;
import 'package:xml/xml.dart' as xml;
import 'package:xml/xml.dart' hide parse;

import 'config_variable.dart';
Expand Down Expand Up @@ -136,7 +135,7 @@ XmlDocument get _nuspec {
if (__nuspec != null) return __nuspec;

try {
__nuspec = xml.parse(chocolateyNuspec.value);
__nuspec = XmlDocument.parse(chocolateyNuspec.value);
} on XmlParserException catch (error) {
fail("Invalid nuspec: $error");
}
Expand Down Expand Up @@ -290,7 +289,7 @@ Future<void> _deploy() async {
///
/// If [allowNone] is `true`, this returns `null` if there are no children of
/// [parent] named [name]. Otherwise, it throws an error.
XmlElement _findElement(XmlParent parent, String name,
XmlElement _findElement(XmlNode parent, String name,
{bool allowNone = false}) {
var elements = parent.findElements(name);
if (elements.length == 1) return elements.single;
Expand Down
4 changes: 2 additions & 2 deletions pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: cli_pkg
version: 1.0.0-beta.10
version: 1.0.0-beta.11
description: Grinder tasks for releasing Dart CLI packages.
homepage: https://github.com/google/dart_cli_pkg

Expand All @@ -25,7 +25,7 @@ dependencies:
string_scanner: '^1.0.0'
test: '^1.0.0'
test_process: '^1.0.0'
xml: '^3.6.0'
xml: '^4.2.0'
yaml: '^2.0.0'

dev_dependencies:
Expand Down