Skip to content
This repository has been archived by the owner on Feb 11, 2024. It is now read-only.

Support for macos. #9

Merged
merged 6 commits into from
Jul 13, 2021
Merged

Support for macos. #9

merged 6 commits into from
Jul 13, 2021

Conversation

mannprerak2
Copy link
Contributor

Closes #4

  • Fixed CMakeList.txt to build wrapper.
  • Bare minimal changes to enable macOS support.

@mannprerak2 mannprerak2 force-pushed the macos_support branch 2 times, most recently from 6a52832 to c419b8c Compare July 10, 2021 12:03
@unsuitable001
Copy link
Contributor

I'll test on Windows. Should we add Windows to CI pipeline also?

@mannprerak2
Copy link
Contributor Author

I'll test on Windows. Should we add Windows to CI pipeline also?

@unsuitable001 the test seem to be passing for windows as well 😄

@mannprerak2
Copy link
Contributor Author

All tests are passing now. All that commit ruckus because I didn't put the binaries in a folder before making a tar. 🙈 🙈

@dcharkes when we add the macOS binary to binaries-v0.0.1 release, we'll need to revert the download URL in this PR, I changed it to my personal repo for running the CI.

dcharkes
dcharkes approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mannprerak2 !

bin/setup.dart Outdated Show resolved Hide resolved
bin/setup.dart Outdated Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
lib/src/constants.dart Outdated Show resolved Hide resolved
@mannprerak2
Copy link
Contributor Author

@dcharkes all changes done.

unsuitable001
unsuitable001 approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@unsuitable001 unsuitable001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@dcharkes dcharkes merged commit a76141c into google:main Jul 13, 2021
@dcharkes
Copy link
Member

@mannprerak2 I only realized the pubspec.yaml and CHANGELOG.md are not updated when I tried to publish a new version 🦀

@mannprerak2
Copy link
Contributor Author

Ah, me neither 🙈🙈

unsuitable001 added a commit to unsuitable001/cronet.dart that referenced this pull request Jul 13, 2021
@unsuitable001
add macos to readme
fd05e7b 
ref google#9
@mannprerak2
Copy link
Contributor Author

Should I create a new PR for updating pubspec and changelog or can we just add it in #8?

@dcharkes
Copy link
Member

Just make a new one, that's a bit cleaner

@unsuitable001
Copy link
Contributor

Oops! I should've read this earlier 😅 . Just pushed a commit adding mac in the readme.

@dcharkes
Copy link
Member

Ah well then just keep it :D

@mannprerak2 mannprerak2 mentioned this pull request Jul 13, 2021
Merged
@hadesss123 hadesss123 mentioned this pull request Jan 16, 2022
Open
@glanium glanium mentioned this pull request Dec 10, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@unsuitable001 unsuitable001 unsuitable001 approved these changes

@dcharkes dcharkes dcharkes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MacOS support
3 participants
@mannprerak2 @unsuitable001 @dcharkes