Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CPU_FEATURES_COMPILED_MIPS_MIPS3D. #240

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

michael-roe
Copy link
Contributor

Added a #define for if the compiler supports the MIPS3D ASE.
I have tested this with gcc.

@google-cla
Copy link

google-cla bot commented May 18, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@gchatelet gchatelet added the enhancement New feature or request label May 19, 2022
@gchatelet gchatelet merged commit 8b3f891 into google:main May 19, 2022
@jculpon
Copy link

jculpon commented May 21, 2022

Xoogler here, dealing with some other bugs related to this CPU feature in MIPS.

Without signing another CLA: is it safe to regard additional MIPS/MIPS_3D based feature flags in open source (USENIX/BSD-3 clause/LIKE netbsd.org style) projects downstream that depending on CPU_FEATURES_COMPILED_MIPS_MIPS3D that have not yet been published openly?

Apologies for any excessively lawyerly anglish jargon.

@gchatelet
Copy link
Collaborator

Hey @jculpon, I'm not entirely sure I understood what you meant here. Can you provide an example?

@jculpon
Copy link

jculpon commented May 23, 2022

Unfortunately, @gchatelet, not without swapping PGP keys. The issue is downtream of @google cpu-features AFAICT. NBD if you're sure there's no new SECURITY/r0 feature issue with MIPS inn this library and its upstream dependencies, but I'd rather not comment further on the public pages.

@gchatelet gchatelet added this to the v0.8.0 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants