Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gitignore #173

Merged
merged 2 commits into from
Jul 6, 2021
Merged

Update gitignore #173

merged 2 commits into from
Jul 6, 2021

Conversation

toor1245
Copy link
Contributor

@toor1245 toor1245 commented Jul 2, 2021

Any suggestions we may include to .gitignore

@toor1245 toor1245 mentioned this pull request Jul 2, 2021
Merged
Mizux
Mizux reviewed Jul 2, 2021
View reviewed changes
.gitignore
@@ -1,5 +1,9 @@
cmake_build/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build*/
cmake_build*/ ?

Copy link
Contributor Author

@toor1245 toor1245 Jul 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about *build*/ or cmake[-_]build*/?

@toor1245
Copy link
Contributor Author

toor1245 commented Jul 2, 2021

I would like to add ignore for VS, for example

.vs/*
out/*

@gchatelet
Copy link
Collaborator

Alright, let's do the following:

# Build folders
build/
cmake_build/
cmake-build-*/
out/

# IDEs / CI temp files
.idea/
.vagrant/
.vscode/
.vs/
*.swp

@toor1245
Copy link
Contributor Author

toor1245 commented Jul 5, 2021

@gchatelet @Mizux updated

@gchatelet gchatelet merged commit dcac7d3 into google:master Jul 6, 2021
@gchatelet
Copy link
Collaborator

Thx!

@gchatelet gchatelet added this to the v0.7.0 milestone Mar 8, 2022
@gchatelet gchatelet added the misc non user facing: internal, cleanup, ci, release process label Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mizux Mizux Mizux approved these changes

Assignees
No one assigned
Labels
misc non user facing: internal, cleanup, ci, release process
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@toor1245 @gchatelet @Mizux