Skip to content

fix non-GHCJS compilation #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix non-GHCJS compilation #1566

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d7599d8
fix non-GHCJS compilation
peterbecich Jan 15, 2022
799f113
move constraint to `funblocks-client.cabal`
peterbecich Jan 17, 2022
9631a55
fix `haskell-src-meta` error
peterbecich Jan 17, 2022
c7a3202
constraint unneeded
peterbecich Feb 9, 2022
c23c080
bump `haskell-src-exts` upper bound
peterbecich Feb 9, 2022
97c27ba
fix `regex-tdfa`
peterbecich Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cabal.project
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,6 @@ packages:
codeworld-server/
codeworld-base/
funblocks-client/

constraints:
ghcjs-dom ==0.9.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really go in the cabal file (presumably in codeworld-api/codeworld-api.cabal) rather than here. To be honest, I'm a little surprised that there's a cabal.project file checked in. That seems wrong...

Copy link
Contributor Author

@peterbecich peterbecich Jan 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea; moved to funblocks-client.cabal.

Regarding the cabal.project file, I know the primary way to build CodeWorld is with the scripts provided; needed for GHC patches, etc. IMO the cabal.project file is useful nonetheless. For one, I'm trying to get the whole project building with Nix #1523 and cabal.project is needed for that (if using https://github.com/input-output-hk/haskell.nix).

2 changes: 1 addition & 1 deletion codeworld-auth/codeworld-auth.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ library
, directory
, filepath
, http-conduit
, jwt >= 0.10.0
, jwt == 0.10.*
, snap-core
, split
, text
Expand Down