Remove syzkaller #4049
Remove syzkaller #4049
Conversation
| @@ -610,7 +609,7 @@ def __init__(self, | |||
| self._command = get_command_line_for_application( | |||
| testcase_path, needs_http=needs_http) | |||
|
|
|||
| def run(self, round_number: int) -> CrashResult: | |||
| def run(self, round_number): | |||
There was a problem hiding this comment.
It looks like there are some unintentional changes here.
| @@ -1243,9 +1198,6 @@ def setup_regular_build(revision, | |||
| build_class = build_setup_host.RemoteRegularBuild | |||
| elif environment.platform() == 'FUCHSIA': | |||
| build_class = FuchsiaBuild | |||
| elif (environment.is_android_cuttlefish() and | |||
There was a problem hiding this comment.
Is this an OK change?
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes this should be fine.
|
TODO: THere are some changes to adb that probably should not be made. |
jonathanmetzman
force-pushed
the
syzkaller
branch
from
dd33cfb
to
0b6d582
Compare
| @@ -1243,9 +1198,6 @@ def setup_regular_build(revision, | |||
| build_class = build_setup_host.RemoteRegularBuild | |||
| elif environment.platform() == 'FUCHSIA': | |||
| build_class = FuchsiaBuild | |||
| elif (environment.is_android_cuttlefish() and | |||
There was a problem hiding this comment.
| @@ -27,8 +27,7 @@ def linkify_kernel_or_lkl_stacktrace_if_needed(crash_info): | |||
| """Linkify Android Kernel or lkl stacktrace.""" | |||
| kernel_prefix = '' | |||
| kernel_hash = '' | |||
| if (environment.is_android_kernel() and | |||
There was a problem hiding this comment.
I think this change is from a revert but @marktefftech do you know what it should be now?
|
Acknowledging that you've tagged me for review at individual LOC, it's my understanding that our kernel fuzzing is now completely decoupled from ClusterFuzz (replaced by Syzbot). So, although I don't own the kernel code, I think it's safe to go ahead and eliminate anything to do with kernel fuzzing assuming it's only being used by Android. |
| @@ -1243,9 +1198,6 @@ def setup_regular_build(revision, | |||
| build_class = build_setup_host.RemoteRegularBuild | |||
| elif environment.platform() == 'FUCHSIA': | |||
| build_class = FuchsiaBuild | |||
| elif (environment.is_android_cuttlefish() and | |||
There was a problem hiding this comment.
Yes this should be fine.
|
(Let me know if you want me to loop in a member of the kernel team, but like I said, this should be fine). |
Yeah if you can loop in someone who worked on this and can confirm we don't need it anymore, that would be great. |
I can confirm; we no longer use Clusterfuzz with our Syzkaller infra. |
+1 |
It's not used anymore, keeping it around complicates things, if we need it again, we can revert.