Skip to content

BigQuery insert: improve the readability of the merge insertErrors logic. #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Dor1s merged 2 commits into from
Jan 21, 2020
Merged

BigQuery insert: improve the readability of the merge insertErrors logic. #1355

Dor1s merged 2 commits into from
Jan 21, 2020

Conversation

@Dor1s
Copy link
Contributor

@Dor1s Dor1s commented Jan 21, 2020

Thanks @oliverchang for the suggestions in #1350.

@Dor1s Dor1s requested a review from oliverchang January 21, 2020 18:57
@googlebot googlebot added the cla: yes CLA signed. label Jan 21, 2020
@Dor1s
Copy link
Contributor Author

Dor1s commented Jan 21, 2020

/gcbrun

@Dor1s Dor1s merged commit b24d391 into master Jan 21, 2020
@oliverchang oliverchang deleted the bq_followup branch January 30, 2020 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliverchang oliverchang oliverchang approved these changes

Assignees

No one assigned

Labels

cla: yes CLA signed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Dor1s @oliverchang @googlebot