Improve support for loops and collection access in TemplateAnalysis
#1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Some collection expressions in soy are guaranteed to never include futures, notably anything returned from a proto or various builtin functions/methods syntax structures, we can take advantage of that to eliminate runtime doneness checks. This generalizes the logic for ranges to apply to things like
```
{for $v in $proto.getFooList()}
{$v} // doesn't need to be checked.
{/for}
```
This is accomplished by analyzing the source of values, if they come from a known resolved source, then we know that accessing them will return a resolved value.
PiperOrigin-RevId: 632631730
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve support for loops and collection access in
TemplateAnalysisSome collection expressions in soy are guaranteed to never include futures, notably anything returned from a proto or various builtin functions/methods syntax structures, we can take advantage of that to eliminate runtime doneness checks. This generalizes the logic for ranges to apply to things like
This is accomplished by analyzing the source of values, if they come from a known resolved source, then we know that accessing them will return a resolved value.