Fix ES6 polyfills to use ToInteger and ToLength #3216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teppeis
commented
Jan 26, 2019
| @@ -58,6 +58,7 @@ testSuite({ | |||
| assertFails(RangeError, () => String.fromCodePoint(noCheck({}))); | |||
| assertFails(RangeError, () => String.fromCodePoint(NaN)); | |||
| assertFails(RangeError, () => String.fromCodePoint(noCheck(/./))); | |||
| assertFails(RangeError, () => String.fromCodePoint(noCheck(undefined))); | |||
There was a problem hiding this comment.
Although it is already working, I added a test just in case.
|
Created internal issue b/123659800 |
blickly
added
the
internal-issue-created
shicks
reviewed
Mar 4, 2019
| opt_end = Number(opt_end); | ||
| if (opt_end < 0) opt_end = Math.max(0, length + opt_end); | ||
| for (var i = Number(opt_start || 0); i < opt_end; i++) { | ||
| var end = opt_end === undefined ? length : $jscomp.toInteger(opt_end); |
There was a problem hiding this comment.
There's a lot of repetitive code here and in other files. What do you think about any of the following:
$jscomp.toIntegertakes a second optional argument for what to return on undefined (may not be quite as smooth as just checking isNaN tho since we still want NaN to map to zero even if undefined maps to length - so not sure if it ends up being worth it).- add a
$jscomp.toPosition(index, length)that handles negative indices and clamping all in one place (but would be nice to handle undefined here as well, and sometimes that's 0 and sometimes it's length - but at least we could just call$jscomp.toPosition(opt_start !== undefined ? opt_start : length, length))
|
Closing this since there have been no comments for over a year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from #2902 (comment)
This change improves compatibility with ECMAScript spec.
Use
ToIntegerto support coercing, null, undefined, float, NaN and larger-than-Int32.Also use
ToLengthto handle negative values and larger-than-2^53.