Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore ES6 module processing of input #2637

Closed
wants to merge 1 commit into from

Conversation

thelgevold
Copy link

@thelgevold thelgevold commented Aug 31, 2017

With this I am proposing a fix to a problem we have been having when integrating Angular builds with versions of Closure Compiler > 20170409.0.0.

It appears that Input processing of ES6 modules was removed in the following commit: d24d175

Putting parts of this back fixes the issue.

The test repo for this can be found here: https://github.com/angular/closure-demo

Some of the input files in the flag file are written in ES6 JavaScript (all the Angular bundles).

With the current release of CC the ES6 input files are not resolved. The compilation fails with errors messages like:

ERROR - required "module$$angular$core" namespace never provided
import * as import0 from '@angular/core';

cc: @alexeagle

@ChadKillingsworth
Copy link
Collaborator

@blickly I thought this was fixed?

@ChadKillingsworth
Copy link
Collaborator

The reason this was originally changed was that anytime ES6 or higher was specified as the input language, a full parse of every input file was required. We don't want to undo that fix.

I'm closing this in favor of #2641 - but it may take a bit to get that one landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants