Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closure-compiler-unshaded v20240317 embeds jakarta.annotation-api #4161

Open
tmortagne opened this issue Mar 26, 2024 · 5 comments
Open

closure-compiler-unshaded v20240317 embeds jakarta.annotation-api #4161

tmortagne opened this issue Mar 26, 2024 · 5 comments
Assignees

Comments

@tmortagne
Copy link

It can cause some conflicts when you depend on both closure-compiler-unshaded and jakarta.annotation-api directly or through other dependencies.

I would have expected it to be a dependency, along with the others declared in the pom file.

@brad4d
Copy link
Contributor

brad4d commented Mar 28, 2024

Thanks for pointing this out.
We're unlikely to do anything about it immediately,
but I expect we will fix it before doing another release.

@tmortagne
Copy link
Author

Thanks @brad4d, that's definitely good enough for me 🙂

@gkdn
Copy link
Member

gkdn commented Mar 28, 2024

@tmortagne Do you know if this has regressed in the latest release?

@niloc132
Copy link
Contributor

Yes, it appears this is a regression in the latest release:

@tmortagne
Copy link
Author

Yes, as detailed by @niloc132 and as I should have mentioned a bit more explicitly in the issue description, it's indeed a regression from v20231112.

@tmortagne tmortagne changed the title closure-compiler-unshaded v20240317 embedss jakarta.annotation-api closure-compiler-unshaded v20240317 embeds jakarta.annotation-api Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants