Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Math.fround not recognized #3141

Closed
kripken opened this issue Nov 9, 2018 · 3 comments
Closed

Math.fround not recognized #3141

kripken opened this issue Nov 9, 2018 · 3 comments
Assignees
@shicks
Labels
P3 triage-done Has been reviewed by someone on triage rotation.

Comments

@kripken
Copy link
Contributor

kripken commented Nov 9, 2018

Compiling with advanced opts, Math.fround is not recognized and is minified into an invalid Math.a. A warning is shown,

JSC_INEXISTENT_PROPERTY_WITH_SUGGESTION: Property fround never defined on Math. Did you mean round? at line 3 character 32

For an example, see here
@kripken kripken mentioned this issue Nov 9, 2018
Merged
@brad4d
Copy link
Contributor

brad4d commented Nov 9, 2018

Created Google internal bug b/119306748

@teppeis teppeis mentioned this issue Nov 10, 2018
Open
kripken added a commit to emscripten-core/emscripten that referenced this issue Nov 10, 2018
@kripken
fix closure minification of Math.*, and remove previous workaround co…
d9d4239 
…de for it. fixes #7472 (#7476)

See google/closure-compiler#3141
@brad4d brad4d added triage-done Has been reviewed by someone on triage rotation. and removed help wanted labels Nov 16, 2018
@brad4d
Copy link
Contributor

brad4d commented Nov 16, 2018

FYI @shicks is actively working to fix this.

Beuc pushed a commit to Beuc/emscripten that referenced this issue Nov 17, 2018
@kripken @Beuc
fix closure minification of Math.*, and remove previous workaround co…
e3891c8 
…de for it. fixes emscripten-core#7472 (emscripten-core#7476)

See google/closure-compiler#3141
@brad4d
Copy link
Contributor

brad4d commented Nov 20, 2018

Fixed in 5d04b3c

@brad4d brad4d closed this as completed Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shicks shicks

Labels
P3 triage-done Has been reviewed by someone on triage rotation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shicks @kripken @brad4d