Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 Out: Captures of Super Fail in MS Edge - breaks async/await transpilation #3101

Closed
ChadKillingsworth opened this issue Oct 11, 2018 · 2 comments

Comments

@ChadKillingsworth
Copy link
Collaborator

The following code will infinitely loop and alert "Child foo" in MS Edge. All other browsers seem to handle this correctly.

class Base {
  foo() {
    alert('base foo');
  }
}

class Child extends Base {
  foo() {
    const parent = () => super.foo;
    alert('Child foo');
    parent().call(this);
  }
}

(new Child()).foo();

This breaks async / await transpilation with ES2015 out.

@brad4d
Copy link
Contributor

brad4d commented Oct 11, 2018

added a comment on PR #3103
a more robust solution is needed

Note that compiling to ES5 is a workaround for this problem.

@brad4d brad4d added the P2 label Oct 11, 2018
ChadKillingsworth added a commit to ChadKillingsworth/closure-compiler that referenced this issue Oct 12, 2018
…ing ES2015 output.

MS Edge 17 does not properly capture references to `super` in an arrow function.
Closes google#3101
ChadKillingsworth added a commit to ChadKillingsworth/closure-compiler that referenced this issue Oct 12, 2018
…ing ES2015 output.

MS Edge 17 does not properly capture references to `super` in an arrow function.
Closes google#3101
ChadKillingsworth added a commit to ChadKillingsworth/closure-compiler that referenced this issue Oct 12, 2018
…ing ES2015 output.

MS Edge 17 does not properly capture references to `super` in an arrow function.
Closes google#3101
ChadKillingsworth added a commit to ChadKillingsworth/closure-compiler that referenced this issue Oct 12, 2018
…ing ES2015+ output.

MS Edge 17 does not properly capture references to `super` in an arrow function.
Closes google#3101
@ChadKillingsworth
Copy link
Collaborator Author

Chakra bug: chakra-core/ChakraCore#5784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants