Make scriptFeatureValidation the default in CompilerTestCase and disa…

…ble it in broken tests

This will run for all tests that don't explicitly disable either feature set validation or ast validation.

NOTE: If this breaks your tests, just add disableValidateScriptFeatures() to your setUp() method.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=202681157

test/com/google/javascript/jscomp/ClosureOptimizePrimitivesTest.java

@@ -38,6 +38,7 @@ public final class ClosureOptimizePrimitivesTest extends CompilerTestCase {
   protected void setUp() throws Exception {
     super.setUp();
     setAcceptedLanguage(LanguageMode.ECMASCRIPT_2017);
+    disableScriptFeatureValidation();
   }
 
   public void testObjectCreateOddParams() {

test/com/google/javascript/jscomp/CollapsePropertiesTest.java

@@ -52,6 +52,7 @@ protected CompilerPass getProcessor(final Compiler compiler) {
   protected void setUp() throws Exception {
     super.setUp();
     enableNormalize();
+    disableScriptFeatureValidation();
   }
 
   @Override

test/com/google/javascript/jscomp/CompilerTestCase.java

@@ -584,7 +584,7 @@ protected void setUp() throws Exception {
     this.allowSourcelessWarnings = false;
     this.astValidationEnabled = true;
     this.typeInfoValidationEnabled = false;
-    this.scriptFeatureValidationEnabled = false;
+    this.scriptFeatureValidationEnabled = true;
     this.checkAccessControls = false;
     this.checkAstChangeMarking = true;
     this.checkLineNumbers = true;

test/com/google/javascript/jscomp/CrossModuleCodeMotionTest.java

@@ -39,6 +39,7 @@ protected int getNumRepetitions() {
   protected void setUp() throws Exception {
     super.setUp();
 
+    disableScriptFeatureValidation();
     parentModuleCanSeeSymbolsDeclaredInChildren = false;
   }
 

test/com/google/javascript/jscomp/Es6ConvertSuperTest.java

@@ -55,6 +55,7 @@ protected void setUp() throws Exception {
     setLanguageOut(LanguageMode.ECMASCRIPT5);
     enableRunTypeCheckAfterProcessing();
     disableTypeCheck();
+    disableScriptFeatureValidation();
   }
 
   @Override

test/com/google/javascript/jscomp/Es6ExtractClassesTest.java

@@ -35,6 +35,7 @@ protected void setUp() throws Exception {
     setLanguageOut(LanguageMode.ECMASCRIPT3);
     disableTypeCheck();
     enableRunTypeCheckAfterProcessing();
+    disableScriptFeatureValidation();
   }
 
   public void testExtractionFromCall() {

test/com/google/javascript/jscomp/Es6RewriteArrowFunctionTest.java

@@ -34,6 +34,7 @@ protected void setUp() throws Exception {
 
     enableTypeInfoValidation();
     enableTypeCheck();
+    disableScriptFeatureValidation();
   }
 
   @Override

test/com/google/javascript/jscomp/Es6RewriteBlockScopedFunctionDeclarationTest.java

@@ -27,6 +27,7 @@ protected void setUp() throws Exception {
     setAcceptedLanguage(LanguageMode.ECMASCRIPT_2015);
     enableTypeCheck();
     enableTypeInfoValidation();
+    disableScriptFeatureValidation();
   }
 
   @Override

test/com/google/javascript/jscomp/Es6RewriteDestructuringTest.java

@@ -27,6 +27,7 @@ protected void setUp() throws Exception {
     setAcceptedLanguage(LanguageMode.ECMASCRIPT_2015);
     disableTypeCheck();
     enableRunTypeCheckAfterProcessing();
+    disableScriptFeatureValidation();
   }
 
   @Override

test/com/google/javascript/jscomp/Es6RewriteModulesTest.java

@@ -34,6 +34,7 @@ protected void setUp() throws Exception {
     // ECMASCRIPT5 to trigger module processing after parsing.
     setLanguage(LanguageMode.ECMASCRIPT_2015, LanguageMode.ECMASCRIPT5);
     enableRunTypeCheckAfterProcessing();
+    disableScriptFeatureValidation();
   }
 
   @Override

test/com/google/javascript/jscomp/Es6RewriteModulesToCommonJsModulesTest.java

@@ -39,6 +39,7 @@ protected void setUp() throws Exception {
     resolutionMode = ModuleLoader.ResolutionMode.BROWSER;
     prefixReplacements = ImmutableMap.of();
     pathEscaper = PathEscaper.ESCAPE;
+    disableScriptFeatureValidation();
   }
 
   @Override

test/com/google/javascript/jscomp/Es6RewriteRestAndSpreadTest.java

@@ -54,6 +54,7 @@ protected void setUp() throws Exception {
     setLanguageOut(LanguageMode.ECMASCRIPT3);
     enableTypeInfoValidation();
     enableTypeCheck();
+    disableScriptFeatureValidation();
   }
 
   // Spreading into array literals.

test/com/google/javascript/jscomp/Es6ToEs3ConverterTest.java

@@ -99,6 +99,7 @@ protected void setUp() throws Exception {
     setLanguageOut(LanguageMode.ECMASCRIPT3);
     enableRunTypeCheckAfterProcessing();
     disableTypeCheck();
+    disableScriptFeatureValidation();
   }
 
   protected final PassFactory makePassFactory(

test/com/google/javascript/jscomp/Es6TypedToEs6ConverterTest.java

@@ -23,6 +23,7 @@ public final class Es6TypedToEs6ConverterTest extends CompilerTestCase {
   protected void setUp() throws Exception {
     super.setUp();
     setAcceptedLanguage(LanguageMode.ECMASCRIPT6_TYPED);
+    disableScriptFeatureValidation();
   }
 
   @Override

test/com/google/javascript/jscomp/EsNextToEs8ConverterTest.java

@@ -30,6 +30,7 @@ protected void setUp() throws Exception {
     setAcceptedLanguage(LanguageMode.ECMASCRIPT_NEXT);
     setLanguageOut(LanguageMode.ECMASCRIPT_2017);
     enableRunTypeCheckAfterProcessing();
+    disableScriptFeatureValidation();
   }
 
   @Override

test/com/google/javascript/jscomp/MinimizeExitPointsTest.java

@@ -20,6 +20,13 @@
  * @author [email protected] (John Lenz)
  */
 public final class MinimizeExitPointsTest extends CompilerTestCase {
+  @Override
+  protected void setUp() throws Exception {
+    super.setUp();
+
+    disableScriptFeatureValidation();
+  }
+
   @Override
   protected CompilerPass getProcessor(final Compiler compiler) {
     return new PeepholeOptimizationsPass(compiler, getName(), new MinimizeExitPoints());

test/com/google/javascript/jscomp/MultiPassTest.java

@@ -40,6 +40,7 @@ protected void setUp() throws Exception {
     setAcceptedLanguage(LanguageMode.ECMASCRIPT5);
     enableNormalize();
     enableGatherExternProperties();
+    disableScriptFeatureValidation();
   }
 
   @Override

test/com/google/javascript/jscomp/SubstituteEs6SyntaxTest.java

@@ -25,6 +25,7 @@ public final class SubstituteEs6SyntaxTest extends CompilerTestCase {
   protected void setUp() throws Exception {
     super.setUp();
     setAcceptedLanguage(CompilerOptions.LanguageMode.ECMASCRIPT_2015);
+    disableScriptFeatureValidation();
   }
 
   @Override