Remove UNKNOWN_TOGGLES error

PiperOrigin-RevId: 565191909
google · Sep 13, 2023 · 385cd58 · 385cd58
1 parent acc6e94
commit 385cd58
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 13 deletions.
diff --git a/src/com/google/javascript/jscomp/ReplaceToggles.java b/src/com/google/javascript/jscomp/ReplaceToggles.java
@@ -51,12 +51,6 @@ class ReplaceToggles implements CompilerPass {
           "CLOSURE_TOGGLE_ORDINALS must be initialized with an object literal mapping strings to"
               + " booleans or unique whole numbers: {0}");
 
-  static final DiagnosticType UNKNOWN_TOGGLE =
-      DiagnosticType.error(
-          "JSC_UNKNOWN_TOGGLE",
-          "goog.readToggleInternalDoNotCallDirectly called with an unknown toggle. If a toggle"
-              + " list is given, it must be exhaustive.");
-
   // NOTE: These values are chosen as negative integers because actual toggle ordinals must always
   // be non-negative (at least zero).  Any negative integers would do to distinguish them from real
   // toggle ordinals, but -1 and -2 are the simplest.
@@ -154,10 +148,6 @@ public void visit(NodeTraversal t, Node n, Node parent) {
         return;
       }
 
-      if (ordinalMapping != null && !ordinalMapping.containsKey(arg.getString())) {
-        compiler.report(JSError.make(n, UNKNOWN_TOGGLE));
-      }
-
       Integer ordinal = ordinalMapping != null ? ordinalMapping.get(arg.getString()) : null;
       if (ordinal == null || ordinal < 0) {
         // No ordinals given: hard-code `true` if explicitly set as true, or `false` otherwise.

diff --git a/test/com/google/javascript/jscomp/ReplaceTogglesTest.java b/test/com/google/javascript/jscomp/ReplaceTogglesTest.java
@@ -16,7 +16,6 @@
 
 package com.google.javascript.jscomp;
 
-
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
@@ -187,11 +186,13 @@ public void testBootstrapOrdinals_booleanAllowsDuplicates() {
 
   @Test
   public void testUnknownToggle() {
-    testError(
+    test(
         lines(
             "var CLOSURE_TOGGLE_ORDINALS = {'foo': 0};",
             "const bar = goog.readToggleInternalDoNotCallDirectly('bar');"),
-        ReplaceToggles.UNKNOWN_TOGGLE);
+        lines(
+            "var CLOSURE_TOGGLE_ORDINALS = {'foo': 0};", //
+            "const bar = false;"));
   }
 
   @Test