Skip to content

Commit

Permalink
Add parsing support for ES6 class private properties
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 722828272
  • Loading branch information
Closure Team authored and copybara-github committed Feb 3, 2025
1 parent 597c475 commit 0b7b374
Show file tree
Hide file tree
Showing 13 changed files with 1,104 additions and 82 deletions.
2 changes: 1 addition & 1 deletion src/com/google/javascript/jscomp/CodeGenerator.java
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ protected void add(Node node, Context context, boolean printComments) {

// Add the property name.
if (!node.isQuotedStringKey()
&& TokenStream.isJSIdentifier(name)
&& (TokenStream.isJSIdentifier(name) || node.isPrivateIdentifier())
&&
// do not encode literally any non-literal characters that were
// Unicode escaped.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
/*
* Copyright 2025 The Closure Compiler Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.google.javascript.jscomp;

import static com.google.javascript.jscomp.TranspilationUtil.cannotConvertYet;

import com.google.errorprone.annotations.CanIgnoreReturnValue;
import com.google.javascript.jscomp.parsing.parser.FeatureSet;
import com.google.javascript.jscomp.parsing.parser.FeatureSet.Feature;
import com.google.javascript.rhino.Node;

/** Transpiles away usages of private properties in ES6 classes. */
final class RewritePrivateClassProperties extends AbstractPeepholeTranspilation {

private final AbstractCompiler compiler;

RewritePrivateClassProperties(AbstractCompiler compiler) {
this.compiler = compiler;
}

@Override
FeatureSet getTranspiledAwayFeatures() {
return FeatureSet.BARE_MINIMUM.with(Feature.PRIVATE_CLASS_PROPERTIES);
}

@Override
@CanIgnoreReturnValue
Node transpileSubtree(Node n) {
if (n.isPrivateIdentifier()) {
cannotConvertYet(compiler, n, "private class properties");
}
return n;
}
}
3 changes: 3 additions & 0 deletions src/com/google/javascript/jscomp/TranspilationPasses.java
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,9 @@ public static void addTranspilationPasses(PassListBuilder passes, CompilerOption
compiler,
compiler.getOptions().getBrowserFeaturesetYearObject(),
compiler.getOptions().getOutputFeatureSet()));
if (compiler.getOptions().needsTranspilationOf(Feature.PRIVATE_CLASS_PROPERTIES)) {
peepholeTranspilations.add(new RewritePrivateClassProperties(compiler));
}
if (compiler.getOptions().needsTranspilationOf(Feature.OPTIONAL_CATCH_BINDING)) {
peepholeTranspilations.add(new RewriteCatchWithNoBinding(compiler));
}
Expand Down
Loading

0 comments on commit 0b7b374

Please sign in to comment.