Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor config paths, fix CLI options #865

Merged
merged 6 commits into from
Aug 9, 2021
Merged

Refactor config paths, fix CLI options #865

merged 6 commits into from
Aug 9, 2021

Conversation

sqrrrl
Copy link
Member

@sqrrrl sqrrrl commented Aug 9, 2021

fix: Honor --project and other CLI options for overriding config file paths

Fixes #859 & #832. Removes PathProxy as no longer needed -- simpler to inline the path resolution in Config and not have the extra layer of indirection.

@sqrrrl sqrrrl requested a review from PopGoesTheWza August 9, 2021 19:29
@google-cla google-cla bot added the cla: yes label Aug 9, 2021
@sqrrrl sqrrrl changed the title Config Refactor config paths, fix CLI options Aug 9, 2021
Copy link
Collaborator

@PopGoesTheWza PopGoesTheWza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sqrrrl LGTM

I suggest the use of 'fs-extra' over 'fs'.

Copy link
Collaborator

@PopGoesTheWza PopGoesTheWza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FYI, I just published updated dotf and ts2gas packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project arguments are ignored in command line
2 participants