Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Issue 626 - default .claspignore #627

Closed
wants to merge 10 commits into from

Conversation

PopGoesTheWza
Copy link
Collaborator

Fixes #626

  • npm run test succeeds.
  • npm run lint succeeds.
  • Appropriate changes to README are included in PR.

@grant
Copy link
Contributor

grant commented May 22, 2019

Let's be focused when we create PRs.
Only solve the issue, don't make any other changes.

@PopGoesTheWza
Copy link
Collaborator Author

I am focused, trust me. But since I am to switch while in the middle of another PR, I prefer to take the opportunity of minor fixes (TODOs, improved typings...) :-P

@grant
Copy link
Contributor

grant commented May 22, 2019

Thanks for the PR. Please make the PR only include changes in these files:

src/dotfile.ts 
tests/commands/push.ts

Move the other changes to a different PR.

@PopGoesTheWza
Copy link
Collaborator Author

@grant I am not that fluent in Git, sorry. I have no idea how to move some changed files to another branch nor how to 'revert' part of the commits.

@grant
Copy link
Contributor

grant commented May 22, 2019

No problem. I recommend always syncing with the latest master branch and working from there.

This may be useful:

https://medium.com/sweetmeat/how-to-keep-a-downstream-git-repository-current-with-upstream-repository-changes-10b76fad6d97

@PopGoesTheWza PopGoesTheWza deleted the issue-626 branch May 22, 2019 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clasp push: UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, open '.claspignore'
3 participants