Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OS specific path separator in Apps Script path #351

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

JeanRemiDelteil
Copy link
Contributor

Fix #72

@grant grant merged commit 9700564 into google:master Oct 15, 2018
@grant
Copy link
Contributor

grant commented Oct 15, 2018

Thanks!

@valen22br
Copy link
Contributor

Hi @grant ,
When are you going to release a stable version that has implemented issue #72?
I installed the version 1.6.3 straight from npm, and the problem persist.
When I build the develop branch, it worked.

Thanks,

@JeanRemiDelteil JeanRemiDelteil deleted the fixPathSeparator branch November 5, 2018 09:02
@JeanRemiDelteil
Copy link
Contributor Author

Hi @grant any hope for a new stable version ? :)

@grant
Copy link
Contributor

grant commented Nov 5, 2018

@valen22br @JeanRemiDelteil I'm working on 2.0 with clasp run. The build I'm working on is very broken. I'm expecting to release next month.
https://github.com/google/clasp/milestone/1

In the meantime, please build clasp from scratch for the latest features.

@valen22br
Copy link
Contributor

Thanks, @grant. I appreciate your feedback. In this meantime, I'll be working with the build version.

@JeanRemiDelteil
Copy link
Contributor Author

@grant Really, you could publish a stable version with this fix, with the build from that time (I do not have any idea why you could not use the build from that time).

Having a currently published broken behaviour really impact us when on-boarding new people or when talking of our use of CLASP in a conference (it would be broken) !
We have to edit the installed package manually !

I'm sorry for insisting, if not possible I understand as well ;p

@grant
Copy link
Contributor

grant commented Dec 5, 2018

@JeanRemiDelteil OK, I'll publish a version Friday.
clasp@2 is actually pretty difficult to implement (clasp run), so I had to delay publishing.

@JeanRemiDelteil
Copy link
Contributor Author

Thank you so much for this !

I'm sorry for insisting, and for not being able to put much effort in the rest of the issues (as CLASP is doing his job very well in all the other aspects :) !)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants