Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix .clasp.json filePushOrder #582

Merged
merged 18 commits into from
Mar 21, 2019
Merged

fix .clasp.json filePushOrder #582

merged 18 commits into from
Mar 21, 2019

Conversation

PopGoesTheWza
Copy link
Collaborator

@PopGoesTheWza PopGoesTheWza commented Mar 21, 2019

Fixes #527

  • npm run test succeeds.
  • npm run lint succeeds.
  • Appropriate changes to README are included in PR.

Successfully tested on a couple of personal projects.

  • order of files listed under filePushOrder is maintained
  • order of files sent through script.projects.updateContent is now correct with files listed under filePushOrder being first
  • if order of files listed under filePushOrder is changed, it is properly reflected after issuing a clasp push

NB: npm run test produces errors but none seems to relate with the changes in this PR

@grant
Copy link
Contributor

grant commented Mar 21, 2019

Looks good to me. Thanks.

@grant grant merged commit ac59751 into google:master Mar 21, 2019
@grant
Copy link
Contributor

grant commented Mar 21, 2019

Note: Master build failed due to exhausted quota.
Should be fine tomorrow.
Not this PR's fault.

Error:

AssertionError: expected 'Resource has been exhausted (e.g. check quota).\n' to include 'Request contains an invalid argument.'

PopGoesTheWza added a commit to PopGoesTheWza/clasp that referenced this pull request Mar 21, 2019
fix .clasp.json `filePushOrder` (google#582)
campionfellin pushed a commit to campionfellin/clasp that referenced this pull request Apr 7, 2019
* change http.ServerRequest into http.IncomingMessage

* removing reference to @types/node

* Typo google#567

* ts2gas dependency to allow upgrades

* sort on filePushOrder fix

* Additionnal fix: unlisted files go last

* fix `filePushOrder` option
@kornthing
Copy link

kornthing commented Jan 18, 2020

I'm using clasp 2.3.0 and I don't think that this merge has fixed the problem. I've made an example on StackOverflow.
I've listed here all opened issues concerned this problem on Git google/clasp:

@PopGoesTheWza
Copy link
Collaborator Author

@kornthing your SO question does not mention using .clasp.json and the filePushOrder option. Please clarify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the filePushOrder option in not working as documented
4 participants