This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Introduce Promise chain for some tests. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah definitely, I was thinking about the callback hell when I was writing the tests, this is definitely more readable. I'd say to add JSDocs to your util method, but other than that looks good to me |
| @@ -30,9 +30,14 @@ var isRequestValid = function(options) { | |||
| return true; | |||
| }; | |||
|
|
|||
| var createPromise = function(func, param) { | |||
There was a problem hiding this comment.
as well as JSDoc I think this would be more readable if these weren't abbreviated. function is a reserved word so I guess func will have to do, but param should probably be parameters to be consistent with the rest of the codebase
|
Would you like me to make these changes? |
|
will do when I have time. forget this until then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thinking the current tests are deep, and using Promise would be better. @lavelle, wdyt?