-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't include protos (and some other dependencies) in jars #251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few nits:
Thanks for the quick review. |
PiperOrigin-RevId: 610795662
Merged a370d05. Thanks for the PR |
Thanks, @l46kok. |
Cadence wise, we're targeting for a quarterly release at a minimum. I'm planning on cutting a 0.4.0 release once all of the Subexpression optimization related changes are in (likely around end of March). If you need a release sooner than that, feel free to cherry pick and create a 0.3.1 branch. I'd be happy to publish to maven central off that. |
Excellent! Thanks. |
@l46kok : https://github.com/Snowflake-Labs/cel-java/tree/smparkes/0.3.1 |
#259 -- you could likely expect this in maven central within O(days). By any chance, would you mind sharing your use-case with us? We're interested in documenting best practices for CEL and would love any feedback. Be happy to follow up over email. |
@l46kok: Thanks! More offline ... |
The cel target in
publish
does not exclude thegoogleapis
protobufs and so the generated classes get included in the jar. Some other stuff likecom.google.rpc.Status
also get pulled in. This causes problems when trying to use the maven central artifact in builds that include the googleapis artifacts from maven central.With this change, only
dev.cel.*
andcel.*
classes are included in the artifact.