-
Notifications
You must be signed in to change notification settings - Fork 22
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Compute navigable expr heights in a separate pass
PiperOrigin-RevId: 609416184
- Loading branch information
1 parent
5ebf44e
commit 4f8f455
Showing
6 changed files
with
211 additions
and
102 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
132 changes: 132 additions & 0 deletions
132
common/src/main/java/dev/cel/common/navigation/ExprHeightCalculator.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| // Copyright 2024 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // https://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package dev.cel.common.navigation; | ||
|
|
||
| import static java.lang.Math.max; | ||
|
|
||
| import com.google.common.collect.ImmutableList; | ||
| import dev.cel.common.ast.CelExpr; | ||
| import dev.cel.common.ast.CelExpr.CelCall; | ||
| import dev.cel.common.ast.CelExpr.CelComprehension; | ||
| import dev.cel.common.ast.CelExpr.CelCreateList; | ||
| import dev.cel.common.ast.CelExpr.CelCreateMap; | ||
| import dev.cel.common.ast.CelExpr.CelCreateStruct; | ||
| import dev.cel.common.ast.CelExpr.CelSelect; | ||
| import java.util.HashMap; | ||
|
|
||
| /** Package-private class to assist computing the height of expression nodes. */ | ||
| final class ExprHeightCalculator { | ||
| // Store hashmap instead of immutable map for performance, such that this helper class can be | ||
| // instantiated faster. | ||
| private final HashMap<Long, Integer> idToHeight; | ||
|
|
||
| ExprHeightCalculator(CelExpr celExpr) { | ||
| this.idToHeight = new HashMap<>(); | ||
| visit(celExpr); | ||
| } | ||
|
|
||
| int getHeight(Long exprId) { | ||
| if (!idToHeight.containsKey(exprId)) { | ||
| throw new IllegalStateException("Height not found for expression id: " + exprId); | ||
| } | ||
|
|
||
| return idToHeight.get(exprId); | ||
| } | ||
|
|
||
| private int visit(CelExpr celExpr) { | ||
| int height = 1; | ||
| switch (celExpr.exprKind().getKind()) { | ||
| case CALL: | ||
| height += visit(celExpr.call()); | ||
| break; | ||
| case CREATE_LIST: | ||
| height += visit(celExpr.createList()); | ||
| break; | ||
| case SELECT: | ||
| height += visit(celExpr.select()); | ||
| break; | ||
| case CREATE_STRUCT: | ||
| height += visitStruct(celExpr.createStruct()); | ||
| break; | ||
| case CREATE_MAP: | ||
| height += visitMap(celExpr.createMap()); | ||
| break; | ||
| case COMPREHENSION: | ||
| height += visit(celExpr.comprehension()); | ||
| break; | ||
| default: | ||
| // This is a leaf node | ||
| height = 0; | ||
| break; | ||
| } | ||
|
|
||
| idToHeight.put(celExpr.id(), height); | ||
| return height; | ||
| } | ||
|
|
||
| private int visit(CelCall call) { | ||
| int targetHeight = 0; | ||
| if (call.target().isPresent()) { | ||
| targetHeight = visit(call.target().get()); | ||
| } | ||
|
|
||
| int argumentHeight = visitExprList(call.args()); | ||
| return max(targetHeight, argumentHeight); | ||
| } | ||
|
|
||
| private int visit(CelCreateList createList) { | ||
| return visitExprList(createList.elements()); | ||
| } | ||
|
|
||
| private int visit(CelSelect selectExpr) { | ||
| return visit(selectExpr.operand()); | ||
| } | ||
|
|
||
| private int visit(CelComprehension comprehension) { | ||
| int maxHeight = 0; | ||
| maxHeight = max(visit(comprehension.iterRange()), maxHeight); | ||
| maxHeight = max(visit(comprehension.accuInit()), maxHeight); | ||
| maxHeight = max(visit(comprehension.loopCondition()), maxHeight); | ||
| maxHeight = max(visit(comprehension.loopStep()), maxHeight); | ||
| maxHeight = max(visit(comprehension.result()), maxHeight); | ||
|
|
||
| return maxHeight; | ||
| } | ||
|
|
||
| private int visitStruct(CelCreateStruct struct) { | ||
| int maxHeight = 0; | ||
| for (CelCreateStruct.Entry entry : struct.entries()) { | ||
| maxHeight = max(visit(entry.value()), maxHeight); | ||
| } | ||
| return maxHeight; | ||
| } | ||
|
|
||
| private int visitMap(CelCreateMap map) { | ||
| int maxHeight = 0; | ||
| for (CelCreateMap.Entry entry : map.entries()) { | ||
| maxHeight = max(visit(entry.key()), maxHeight); | ||
| maxHeight = max(visit(entry.value()), maxHeight); | ||
| } | ||
| return maxHeight; | ||
| } | ||
|
|
||
| private int visitExprList(ImmutableList<CelExpr> createListExpr) { | ||
| int maxHeight = 0; | ||
| for (CelExpr expr : createListExpr) { | ||
| maxHeight = max(visit(expr), maxHeight); | ||
| } | ||
| return maxHeight; | ||
| } | ||
| } |
Oops, something went wrong.