Fix creation of proto values containing oneof fields. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristonianJones
force-pushed
the
reflection-fixes
branch
from
7d14a73
to
3a21a04
Compare
JimLarson
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#36 Fixes setting proto oneof fields during object construction.
In go, oneof fields have a wrapper struct which is generated that is not a
proto.Messageinstance; however, all wrappers for oneof fields only contain a single field definition. This
fix relies on this behavior to detect and set oneof fields properly in object construction
expressions like:
v1.Expr{id: 1, literal_expr: v1.Literal{string_value: 'oneof-test'}}Note, the above expression is not quite as easy to use as the proto textformat where the
type of
literal_exprfield would be deduced at runtime without the developer needingto specify it.