Support conversion of primitive values to pointer types. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madi8229
reviewed
Jun 7, 2018
common/types/bool_test.go
Outdated
| ptrType := true | ||
| refType := reflect.TypeOf(&ptrType) | ||
| val, err := True.ConvertToNative(refType) | ||
| if err != nil || IsError(val) || !*val.(*bool) { |
There was a problem hiding this comment.
I found only bool checks IsError(val). Does other types need to also check IsError(val)?
There was a problem hiding this comment.
Ah, no, that was leftover from a previous test case that I'd copied. Removed.
common/types/double_test.go
Outdated
| ptrType := float32(0) | ||
| val, err := Double(3.1415).ConvertToNative(reflect.TypeOf(&ptrType)) | ||
| if err != nil || *val.(*float32) != 3.1415 { | ||
| t.Errorf("Got '%v', wanted 3.1415", val) |
There was a problem hiding this comment.
err may need to be logged when err != nil
TristonianJones
force-pushed
the
proto2-primitive-support
branch
from
ea9f0de
to
d382e41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#35 Support conversion to pointer type for primitive values.
During proto2 message construction, primitive fields are set by pointer rather than
by value (as they are in proto3). This pull request ensures that primitive values can be
converted to pointer references.