Fix: use of sized deallocation in base/memory.h wo check#558
Open
sitano wants to merge 1 commit intogoogle:masterfrom
Open
Fix: use of sized deallocation in base/memory.h wo check#558sitano wants to merge 1 commit intogoogle:masterfrom
sitano wants to merge 1 commit intogoogle:masterfrom
Conversation
Dependant projects that do not use `-fsized-deallocation`
would not compile with the call to delete(void*, size_t, align).
There are other places that already check for
`defined(__cpp_sized_deallocation)` and this patch just shares
this practice.
Testing:
// fix .bazelrc to have:
build --cxxopt=-fno-sized-deallocation
$ bazel build --verbose_failures //base:\*
Signed-off-by: Ivan Prisyazhnyy <john.koepi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependant projects that do not use
-fsized-deallocationwould not compile with the call to delete(void*, size_t, align).There are other places that already check for
defined(__cpp_sized_deallocation)and this patch just shares this practice.Testing: