Skip to content
This repository was archived by the owner on Sep 24, 2025. It is now read-only.

Pull @rules_rust in cargo_raze_repositories().#396

Merged
acmcarther merged 1 commit intogoogle:mainfrom
PiotrSikora:rules_rust
Mar 15, 2021
Merged

Pull @rules_rust in cargo_raze_repositories().#396
acmcarther merged 1 commit intogoogle:mainfrom
PiotrSikora:rules_rust

Conversation

@PiotrSikora
Copy link
Copy Markdown
Contributor

Signed-off-by: Piotr Sikora piotrsikora@google.com

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora PiotrSikora marked this pull request as ready for review March 6, 2021 23:17
@PiotrSikora PiotrSikora requested a review from acmcarther as a code owner March 6, 2021 23:17
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

cc @UebelAndre

Copy link
Copy Markdown
Contributor

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for fixing that 😀

@UebelAndre
Copy link
Copy Markdown
Contributor

Oh, actually, I'm not sure if the call to rust_repositories should be in that file. Users may not want to call that and instead setup toolchains themselves using rust_repository_set directly or something.

@PiotrSikora
Copy link
Copy Markdown
Contributor Author

Oh, actually, I'm not sure if the call to rust_repositories should be in that file. Users may not want to call that and instead setup toolchains themselves using rust_repository_set directly or something.

rules_repositories() configures a few default rust_repository_set(), but it doesn't prevent people from adding more on their own, so I don't believe it breaks any real use cases.

@UebelAndre
Copy link
Copy Markdown
Contributor

That sounds right to me. Then I think this change is good. Thanks again!

@acmcarther
Copy link
Copy Markdown
Member

LGTM

@acmcarther acmcarther merged commit 272f80b into google:main Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants