-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update main.py #127
base: main
Are you sure you want to change the base?
Update main.py #127
Conversation
We add comments for better readability, organizes imports, and follows PEP8 conventions. I've also added placeholders where the code seems incomplete, specifically for the "cloud" command and the main logic execution.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these need to stay in all files for Google style.
ll.getLogger("caliban.main").setLevel(logging.ERROR) | ||
t = Terminal() | ||
|
||
|
||
def run_app(arg_input): | ||
"""Main function to run the Caliban app. Accepts a Namespace-type output of an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please install the pre-commit
hooks?
pip install pre-commit
pre-commit --install
and then
pre-commit run --all-files
if you want to trigger them manually. This will clear up all formatting differences so we can look at what's actually changed. Thank you!
We add comments for better readability, organizes imports, and follows PEP8 conventions. I've also added placeholders where the code seems incomplete, specifically for the "cloud" command and the main logic execution.