Skip getVfsStats when file does not exist #1847
Conversation
|
@dims when this is merged, which version of k8s can be fixed, v1.9.1 or master branch of k8s? |
|
@pineking neither one ... we will need this to get in first, then propose a PR to pull in a fresh cadvisor (to fix master) and then backport it to 1.9 branch |
|
Can we add a |
|
@dashpole yep, i can do that |
dims
force-pushed
the
skip-get-vfs-stats-when-mountpoint-does-not-exist
branch
from
5ed1d63 to
2448178
Compare
|
/test pull-cadvisor-e2e |
|
@dashpole something wrong with the build? local make looks file (http://paste.openstack.org/show/636661/) |
|
looks like it has been failing for a few days: https://k8s-testgrid.appspot.com/sig-node-cadvisor#cadvisor-kubelet. Not sure why. |
|
Thanks @dashpole |
|
Can you regenerate the assets? I think the change from 2017->2018 made the tests fail (happened in k/k as well :) |
|
Classic new year's bugs |
There are a lot of spurious exceptions in the kubernetes kubelet logs like: E1018 21:03:09.616581 22780 fs.go:332] Stat fs failed. Error: no such file or directory Since we know that calling syscall.Statfs will just fail when the path does not exist, we should just skip making the call. NOTE: fixing 2017->2018 problems in build by running `./build/jenkins_e2e.sh`
dims
force-pushed
the
skip-get-vfs-stats-when-mountpoint-does-not-exist
branch
from
2448178 to
5f8eea9
Compare
|
:) |
Automatic merge from submit-queue. UPSTREAM: google/cadvisor: 1847: Skip getVfsStats when file does not exist google/cadvisor#1847 xref https://bugzilla.redhat.com/show_bug.cgi?id=1511576 @eparis @derekwaynecarr **Reviewer note** Drops two copyright year changes included in the upstream commit.
There are a lot of spurious exceptions in the kubernetes kubelet logs
like:
E1018 21:03:09.616581 22780 fs.go:332] Stat fs failed. Error: no such
file or directory
Since we know that calling syscall.Statfs will just fail when the path
does not exist, we should just skip making the call.
Fix for kubernetes/kubernetes#35062