avatar: reduce number of shards #567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should merge this PR only when the flakiness will be tracked down. Otherwise it will just fail at 100%. |
Having too many shards extends the total testing time. 4 shards is a good compromise. Also, run all the shards and does not skip when one shard is failing
SilverBzH
force-pushed
the
charliebout/avatar_reduce_shards
branch
from
ee391b9
to
446da28
Compare
|
I am closing this PR. The test is irrelevant, it take the same times for 4 or 24 shards. I'll let it untouched. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having too many shards extends the total testing time. 4 shards is a
good compromise.
Also, run all the shards and does not skip when one shard is failing