Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return ATT_Error_Response on rejected write request #549

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Return ATT_Error_Response on rejected write request #549

merged 1 commit into from
Sep 9, 2024

Conversation

zxzxwu
Copy link
Collaborator

@zxzxwu zxzxwu commented Sep 7, 2024

No description provided.

@zxzxwu
Copy link
Collaborator Author

zxzxwu commented Sep 7, 2024

cc @wescande

@zxzxwu
Copy link
Collaborator Author

zxzxwu commented Sep 7, 2024

I think it makes more sense if GATT client also raises ATT_Error instead of ProtocolError?

@barbibulle
Copy link
Collaborator

I think it makes more sense if GATT client also raises ATT_Error instead of ProtocolError?

ATT_Error is a subclass of ProtocolError, with the namespace set to att, so it would be perfectly fine to have the client raise ATT_Error.

@zxzxwu zxzxwu merged commit ac0cff4 into google:main Sep 9, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbibulle barbibulle barbibulle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxzxwu @barbibulle