basic broadcast assistant functionality #529
Conversation
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for | ||
|
|
||
| """LE Audio - Audio Stream Control Service""" |
There was a problem hiding this comment.
If we are going to split Basic Audio Profile into different services, I think the directory name profiles will become not so precise? Though many other services have been there for some time.
There was a problem hiding this comment.
It's Ok for the profiles directory to contain files that represent entire profiles (ex: tmap.py or bap.py), just one service (ex: bass.py, battery_service.py) or even just multi-profile shared definitions (ex: le_audio.py). Some profiles share elements, so it's convenient to break those out, and some profiles are large, so splitting them into individual services also makes sense when needed. So the profiles directory is just a container for "implementation and definition files associated with different profiles".
bumble/profiles/tmap.py
Outdated
| else: | ||
| self.role = None |
There was a problem hiding this comment.
Would it be better to raise an error here? (and make role not optional)
barbibulle
force-pushed
the
gbg/broadcast-assistant
branch
from
8b82cd7
to
9dd814f
Compare
Adds some basic broadcast assistant support to the auracast.py app.
This is still very basic, and might not completely work yet, but since it includes a small reorganization of some of the profile implementation files, I'd like to merge this soon so that the branch doesn't end up with conflicts later on if changes are made to the reorganized profiles.