Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic RPA support #522

Merged
merged 2 commits into from
Aug 6, 2024
Merged

add basic RPA support #522

merged 2 commits into from
Aug 6, 2024

Conversation

barbibulle
Copy link
Collaborator

This PR adds a device config to tell the Device object to automatically create a random private address at power on. Optionally, there's also a periodic task to update the RPA based on a configurable timeout.
For manual control, the update_rpa method can be called.

@zxzxwu
Copy link
Collaborator

zxzxwu commented Aug 5, 2024

I am thinking whether RPA rotation should be provided by Device itself? Providing attributes to support host-side security could be great, but handling them automatically is a little bit complicated (there are many Android issues due to the same behavior). Since Bumble is not a product, letting users rotate RPA manually should be enough.

@barbibulle
Copy link
Collaborator Author

I am thinking whether RPA rotation should be provided by Device itself? Providing attributes to support host-side security could be great, but handling them automatically is a little bit complicated (there are many Android issues due to the same behavior). Since Bumble is not a product, letting users rotate RPA manually should be enough.

I agree. This is why in this PR, automatic RPA update is off by default. Users can call Device.update_rpa() if they want to. The le_privacy_enabled is only a convenient way to have the device pick an RPA at power on, which can be useful if you need an RPA with some of the example code or apps but without writing code: just set the property in a device config.

@barbibulle barbibulle merged commit 4433184 into main Aug 6, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants